Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement: Add client credentials location parameter for Client Credentials OAuth flow #9730

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

alexander-sil
Copy link

@alexander-sil alexander-sil commented Mar 22, 2024

Description

I have developed a fix to make the user able to send OAuth client credentials (that is, client ID and secret) in the request body. The fix consists of an additional dropdown box to determine the authActions file flow.

Motivation and Context

Fixes #9711
This change is needed by niche use cases, e.g. when the partner client does not fully comply to the Section 2.3.1 of RFC 6479 standard - sometimes due to requiring the client to send the client credentials in the JSON body content. This is experienced by me first-hand, as I have to develop an API to integrate with such example of a service.

How Has This Been Tested?

Manual quality assurance (QA).

Screenshots (if appropriate):

スクリーンショット 2024-03-22 150802

Checklist

My PR contains...

  • No code changes (src/ is unmodified: changes to documentation, CI, metadata, etc.)
  • Dependency changes (any modification to dependencies in package.json)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes to a public API (config options, System API, major UI change, etc).
  • are breaking changes to a private API (Redux, component props, utility functions, etc.).
  • are breaking changes to a developer API (npm script behavior changes, new dev system dependencies, etc).
  • are not breaking changes.

Documentation

  • My changes do not require a change to the project documentation.
  • My changes require a change to the project documentation.
  • If yes to above: I have updated the documentation accordingly.

Automated tests

  • My changes can not or do not need to be tested.
  • My changes can and should be tested by unit and/or integration tests.
  • If yes to above: I have added tests to cover my changes.
  • If yes to above: I have taken care to cover edge cases in my tests.
  • All new and existing tests passed.

@alexander-sil alexander-sil changed the title Add client credentials location parameter for Client Credentials OAuth flow Improvement: Add client credentials location parameter for Client Credentials OAuth flow Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant