Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed #9595 - Primitve data not collapsible #9639

Conversation

dakkkshh
Copy link
Contributor

Primitve data not collapsible. Changed hideSelfOnExpand prop to false for primitive-model

Description

Primitive data can be expaned but can not be collapsed. This is due to the prop hideSelfOnExpand which used to check the depth of data. I set it to false. Now whether the data is primitve / not, it can be collapsed.

Motivation and Context

"Fixes #9595 "

How Has This Been Tested?

I manually tested the fix by launching the application and checking whether primitive data can be collapsed or not. I also rna the test script and here is the result:
Total Tests: 462
Passed: 459
Failed: 0
Pending: 3

Screenshots (if appropriate):

Checklist

My PR contains...

  • No code changes (src/ is unmodified: changes to documentation, CI, metadata, etc.)
  • Dependency changes (any modification to dependencies in package.json)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes to a public API (config options, System API, major UI change, etc).
  • are breaking changes to a private API (Redux, component props, utility functions, etc.).
  • are breaking changes to a developer API (npm script behavior changes, new dev system dependencies, etc).
  • are not breaking changes.

Documentation

  • My changes do not require a change to the project documentation.
  • My changes require a change to the project documentation.
  • If yes to above: I have updated the documentation accordingly.

Automated tests

  • My changes can not or do not need to be tested.
  • My changes can and should be tested by unit and/or integration tests.
  • If yes to above: I have added tests to cover my changes.
  • If yes to above: I have taken care to cover edge cases in my tests.
  • All new and existing tests passed.

Copy link
Contributor

@glowcloud glowcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @dakkkshh,

Thanks for this fix! Please take a look at my comment to see the suggested change.

The PrimitiveModel component was also moved to the json-schema-5 plugin in 3b72ee1. Could you update your PR to include this change there?

src/core/components/primitive-model.jsx Outdated Show resolved Hide resolved
@glowcloud
Copy link
Contributor

Thanks for the changes! LGTM!

@glowcloud glowcloud merged commit 450bb99 into swagger-api:master May 8, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

a11y: Once you expand a data element of a schema, there is no way to collapse it again.
2 participants