Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Json spec overwrite attribute after fetch spec from URLs #9614

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

daotoan-hd
Copy link

@daotoan-hd daotoan-hd commented Feb 19, 2024

Description

Motivation and Context

  • Sometimes the service returns JSON spec is underlying gateway domain. Service doesn't need to know about it's domain. And the server domain could be controlled by DevOps team. In order to do that, instead of passing the domain ENV into the service and add code for spec generator. We could overwrite the spec attribute after fetch

How Has This Been Tested?

I'm just testing on local with
npm run dev

Screenshots (if appropriate):

image

Checklist

My PR contains...

  • No code changes (src/ is unmodified: changes to documentation, CI, metadata, etc.)
  • Dependency changes (any modification to dependencies in package.json)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes to a public API (config options, System API, major UI change, etc).
  • are breaking changes to a private API (Redux, component props, utility functions, etc.).
  • are breaking changes to a developer API (npm script behavior changes, new dev system dependencies, etc).
  • are not breaking changes.

Documentation

  • My changes do not require a change to the project documentation.
  • My changes require a change to the project documentation.
  • If yes to above: I have updated the documentation accordingly.

Automated tests

  • My changes can not or do not need to be tested.
  • My changes can and should be tested by unit and/or integration tests.
  • If yes to above: I have added tests to cover my changes.
  • If yes to above: I have taken care to cover edge cases in my tests.
  • All new and existing tests passed.

@daotoan-hd daotoan-hd changed the title Support Json spec overwrite atribute after fetch spec from URLs Support Json spec overwrite attribute after fetch spec from URLs Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant