Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add keyboard shortcut to close modal on Esc key press #9290

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Yogesh01000100
Copy link

@Yogesh01000100 Yogesh01000100 commented Oct 8, 2023

Description

This PR adds the functionality to close the modal when the "Esc" key is pressed in the AuthorizationPopup component.

Motivation and Context

This change is required to improve the user experience by allowing users to close the modal using the "Esc" key, providing a more intuitive way to dismiss the modal.

Resolves #9200

How Has This Been Tested?

I manually tested this feature in the following ways:

  • Opened the modal and pressed the "Esc" key to ensure it closes.
  • Checked that the modal remains open when other keys are pressed.
  • Ensured that the functionality does not interfere with other components or actions.

Screenshots (if appropriate):

Checklist

My PR contains...

  • No code changes (src/ is unmodified: changes to documentation, CI, metadata, etc.)
  • Dependency changes (any modification to dependencies in package.json)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes to a public API (config options, System API, major UI change, etc).
  • are breaking changes to a private API (Redux, component props, utility functions, etc.).
  • are breaking changes to a developer API (npm script behavior changes, new dev system dependencies, etc).
  • are not breaking changes.

Documentation

  • My changes do not require a change to the project documentation.
  • My changes require a change to the project documentation.
  • If yes to above: I have updated the documentation accordingly.

Automated tests

  • My changes can not or do not need to be tested.
  • My changes can and should be tested by unit and/or integration tests.
  • If yes to above: I have added tests to cover my changes.
  • If yes to above: I have taken care to cover edge cases in my tests.
  • All new and existing tests passed.

Signed-off-by: Yogesh01000100 <yogeshone678@gmail.com>
@Yogesh01000100
Copy link
Author

Yogesh01000100 commented Oct 9, 2023

@char0n Could you please help to merge this pull request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE REQUEST] Add shortcuts keyboards
1 participant