Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin swagger-client dependency to exact version #8014

Closed
wants to merge 1 commit into from
Closed

Pin swagger-client dependency to exact version #8014

wants to merge 1 commit into from

Commits on May 6, 2022

  1. Pin swagger-client dependency to exact version

    On at least 3 occasions, including this morning, updates to swagger-client have caused versions of swagger-ui to stop working.
    
    This morning, [changes to swagger-client's usage of `btoa`](swagger-api/swagger-js@4832f32) were [released](https://github.com/swagger-api/swagger-js/commits/v3.18.5). Our build, depending on swagger-ui-react 4.1.0, failed with errors about the absence of the btoa module. We traced these errors to swagger-ui's bundled `swagger-ui.js`, which included some code from an older swagger-client version that expected `btoa` to still be present.
    
    Previous [issues include](#7436) the removal of [isomorphic-form-data](swagger-api/swagger-js#2154) around swagger-ui release 3.51.2, and the removal of [querystring-browser](swagger-api/swagger-js#2288) around swagger-ui [release 3.52.5](#7556)
    
    By pinning the swagger-client dependency to an exact version, issues with transitive dependencies should be mitigated. Of course, other dependencies may still pose similar problems, but swagger-client has been the recurring theme so far.
    emanb29 committed May 6, 2022
    Configuration menu
    Copy the full SHA
    a80cc29 View commit details
    Browse the repository at this point in the history