Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(js-yaml): update our main YAML parser to v4.1.0 #7455

Merged
merged 2 commits into from Aug 9, 2021

Conversation

char0n
Copy link
Member

@char0n char0n commented Aug 6, 2021

Closes #6804

Description

Updates js-yaml library to 4.1 version.

Motivation and Context

We're using relatively old version of js-yaml. 4.x branch is a new one with huge amount of fixes.

My PR contains...

  • No code changes (src/ is unmodified: changes to documentation, CI, metadata, etc.)
  • Dependency changes (any modification to dependencies in package.json)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes to a public API (config options, System API, major UI change, etc).
  • are breaking changes to a private API (Redux, component props, utility functions, etc.).
  • are breaking changes to a developer API (npm script behavior changes, new dev system dependencies, etc).
  • are not breaking changes.

Documentation

  • My changes do not require a change to the project documentation.
  • My changes require a change to the project documentation.
  • If yes to above: I have updated the documentation accordingly.

Automated tests

  • My changes can not or do not need to be tested.
  • My changes can and should be tested by unit and/or integration tests.
  • If yes to above: I have added tests to cover my changes.
  • If yes to above: I have taken care to cover edge cases in my tests.
  • All new and existing tests passed.

@char0n char0n added version: 3.x type: enhancement dependencies Pull requests that update a dependency file labels Aug 6, 2021
@char0n char0n self-assigned this Aug 6, 2021
@char0n
Copy link
Member Author

char0n commented Aug 6, 2021

This PR will fail currently. It should report success the moment we merge swagger-api/swagger-js#1867 and release a new version of swagger-client and bump it in this PRs package.json.

@char0n char0n merged commit ee40b00 into master Aug 9, 2021
@char0n char0n deleted the char0n/js-yaml-4-1-0-update branch August 12, 2021 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file type: enhancement version: 3.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant