Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: optional empty validation #7003

Merged
merged 3 commits into from Mar 3, 2021
Merged

fix: optional empty validation #7003

merged 3 commits into from Mar 3, 2021

Commits on Feb 26, 2021

  1. refactor: early return to clearify cases 

    I decided to refactor the validation condition to more readable state.
I think this is even more readable then the comment before

Signed-off-by: mathis-m <mathis.michel@outlook.de>
    @mathis-m
    mathis-m committed Feb 26, 2021
    Configuration menu
    Copy the full SHA
    2fb53ec View commit details
    Browse the repository at this point in the history

  2. fix: optional empty validation 

    internal logic does send null to validation in case of empty parameter input.

Signed-off-by: mathis-m <mathis.michel@outlook.de>
    @mathis-m
    mathis-m committed Feb 26, 2021
    Configuration menu
    Copy the full SHA
    8ab0a11 View commit details
    Browse the repository at this point in the history

Commits on Mar 3, 2021

  1. Merge branch 'master' into ft/optional-empty-validation

    @tim-lai
    tim-lai committed Mar 3, 2021
    Configuration menu
    Copy the full SHA
    a80782d View commit details
    Browse the repository at this point in the history