New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use named import for fast-json-patch
update to 2.2.0
#1464
Use named import for fast-json-patch
update to 2.2.0
#1464
Conversation
no to use undocumented default export. Fixes swagger-api#1460
Now it should work fine with named imports.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tomalec Thanks for the PR! It's been awhile, but can you rebase, resolve merge conflicts, and apply suggestions. One is a lint error. Once done, this PR will be merged.
Co-authored-by: Tim Lai <timothy.lai@gmail.com>
Co-authored-by: Tim Lai <timothy.lai@gmail.com>
@tim-lai thanks for the review. |
@tomalec please resolve merge conflicts as well. Thanks! |
Along with that update fast-json-patch to v2.2.1 Refs #1464
Along with that update fast-json-patch to v2.2.1 Refs #1464
Description
fast-json-patch
fast-json-patch
back to the current2.2.0
Motivation and Context
As reported at Starcounter-Jack/JSON-Patch#233 and #1460 (Fixes #1460) there was a problem initializing Swagger with latest
fast-json-patch
. It occurred to be related to backward incompatible change related to undocumented default export. We will revert this change, and release a new version to support this and many other projects that are currently usingimport jsonPatch from 'fast-json-patch'
.However, we recommend to use named or star imports:
Those worked with old versions, works fine with 2.2.0, and we plan long term support for such import.
So you can use it with current versions without a need to wait for our fix.
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
package.json
)Checklist:
npm test
locally, but they were failing even on master :(