Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build on Windows OS #3882

Merged
merged 2 commits into from
Feb 14, 2021
Merged

Fix build on Windows OS #3882

merged 2 commits into from
Feb 14, 2021

Conversation

strangelookingnerd
Copy link
Contributor

@frantuma Validating the SNAPSHOT builds for refs #3836 on my end

  • Files.copy(...) failed with DirectoryNotEmptyException (see docs)
  • URI.create(...) failed due to backwards slashes in outJarPath

Copy link
Member

@frantuma frantuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! just 2 comments before merging


}
}
private static void extract(String inPath, String outPath) throws Exception {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would use spaces instead of tabs..

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right, fixed it. In my defense the formatters in the Coding-Standards give me 404s.

@frantuma frantuma merged commit 8f16944 into swagger-api:master Feb 14, 2021
@frantuma
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants