Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump cobra to 1.3.0, replace completion command #47

Merged
merged 1 commit into from Dec 15, 2021
Merged

Bump cobra to 1.3.0, replace completion command #47

merged 1 commit into from Dec 15, 2021

Conversation

svix-frank
Copy link
Contributor

@svix-frank svix-frank commented Jul 11, 2021 •
edited

The new version of cobra autogenerates a completion command which has the same interface as our custom one, so we can update and drop our command (fewer things to support)! 馃帀

@svix-frank svix-frank changed the title Bump cobra to 1.6.1, replace completion command Bump cobra to 1.8.1, replace completion command Jul 11, 2021
@svix-frank svix-frank requested review from tasn and a team July 11, 2021 03:40
svix-liam
svix-liam previously approved these changes Jul 11, 2021
View reviewed changes
@svix-frank svix-frank changed the title Bump cobra to 1.8.1, replace completion command Bump cobra to 1.2.1, replace completion command Jul 11, 2021
@tasn
Copy link
Member

tasn commented Jul 11, 2021

馃帀

@fcjr
Copy link
Contributor

fcjr commented Jul 12, 2021 •
edited

This might be minor but I realized the short desc for the generated command starts with a lowercase letter which looks pretty unprofessional given the rest are capitalized. (The help desc is autogenerated with an uppercase so we can't just change to all lowercase). I made a PR to upstream, gonna hold off on merging this until its released. spf13/cobra#1455

@svix-frank
Copy link
Contributor Author

This might be minor but I realized the short desc for the generated command starts with a lowercase letter which looks pretty unprofessional given the rest are capitalized. (The help desc is autogenerated with an uppercase so we can't just change to all lowercase). I made a PR to upstream, gonna hold off on merging this until its released. spf13/cobra#1455

My cobra patch finally got merged, just waiting for them to make another release.

@tasn
Copy link
Member

tasn commented Dec 11, 2021

馃帀

@svix-frank svix-frank changed the title Bump cobra to 1.2.1, replace completion command Bump cobra to 1.3.0, replace completion command Dec 14, 2021
@svix-frank svix-frank merged commit f08d512 into main Dec 15, 2021
@svix-frank svix-frank deleted the frank/bump_cobra branch December 15, 2021 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tasn tasn tasn approved these changes

@svix-liam svix-liam Awaiting requested review from svix-liam

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@svix-frank @tasn @fcjr @svix-liam