Fix multipassCount initialization #1206
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The first pass receives multipasscount as undefined, the second pass as 0. This leads to issues due to the prefixIds allowing 2 passes before bailing.
|
Duplicate of #1177 , which implements a similar fix for this issue, and adds tests as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous implementation initialized
info.multipassCountin the optimize callback, and before counter is incremented. Thus, on the first pass, it isundefined, on the second it is 0, third it is 1, etc.This is problematic since the prefixIds plugin multipass check will pass for both undefined and 0, causing it to run twice (as opposed to once, which was the intention of this feature to prevent accumulating prefixes).