Setup recommended eslint preset (#1345)

This is usually enough to prevent silly mistakes. Formatting will be done by prettier after merging pull requests.
svg · Feb 19, 2021 · a7cc20b · a7cc20b
1 parent feefdc0
commit a7cc20b
Show file tree

Hide file tree

Showing 24 changed files with 657 additions and 84 deletions.
diff --git a/.editorconfig b/.editorconfig
diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
@@ -26,3 +26,4 @@ jobs:
       - run: npm ci
       - run: npm test
       - run: npm run test-browser
+      - run: npm run lint
diff --git a/.jshintignore b/.jshintignore
diff --git a/.jshintrc b/.jshintrc
diff --git a/examples/test.js b/examples/test.js
@@ -49,7 +49,7 @@ FS.readFile(filepath, 'utf8', function(err, data) {
         throw err;
     }
 
-    const result = svgo.optimize(data, {path: filepath, ...config});
+    const result = optimize(data, {path: filepath, ...config});
 
     console.log(result);
 

diff --git a/lib/svgo-node.js b/lib/svgo-node.js
@@ -39,6 +39,7 @@ const loadConfig = async (configFile, cwd = process.cwd()) => {
     }
   }
   let dir = cwd;
+  // eslint-disable-next-line no-constant-condition
   while (true) {
     const file = path.join(dir, "svgo.config.js");
     if (await isFile(file)) {

diff --git a/lib/svgo/coa.js b/lib/svgo/coa.js
@@ -1,4 +1,3 @@
-/* jshint quotmark: false */
 'use strict';
 
 const FS = require('fs');
@@ -46,7 +45,7 @@ module.exports = function makeProgram(program) {
         .action(action);
 }
 
-async function action(args, opts) {
+async function action(args, opts, command) {
     var input = opts.input || args;
     var output = opts.output;
     var config = {}
@@ -91,7 +90,9 @@ async function action(args, opts) {
         !opts.stdin &&
         !opts.folder &&
         process.stdin.isTTY === true
-    ) return program.help();
+    ) {
+      return command.help();
+    }
 
     if (typeof process == 'object' && process.versions && process.versions.node && PKG && PKG.engines.node) {
         var nodeVersion = String(PKG.engines.node).match(/\d*(\.\d+)*/)[0];

diff --git a/lib/svgo/jsAPI.js b/lib/svgo/jsAPI.js
@@ -225,7 +225,6 @@ JSAPI.prototype.renameElem = function(name) {
  * @return {Object|Undefined}
  */
  JSAPI.prototype.computedAttr = function(name, val) {
-    /* jshint eqnull: true */
     if (!arguments.length) return;
 
     for (var elem = this; elem && (!elem.hasAttr(name) || !elem.attr(name).value); elem = elem.parentNode);

diff --git a/lib/svgo/svg2js.js b/lib/svgo/svg2js.js
@@ -4,7 +4,7 @@ var SAX = require('sax'),
     JSAPI = require('./jsAPI.js'),
     CSSClassList = require('./css-class-list'),
     CSSStyleDeclaration = require('./css-style-declaration'),
-    entityDeclaration = /<!ENTITY\s+(\S+)\s+(?:'([^\']+)'|"([^\"]+)")\s*>/g;
+    entityDeclaration = /<!ENTITY\s+(\S+)\s+(?:'([^']+)'|"([^"]+)")\s*>/g;
 
 var config = {
     strict: true,