Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Introduce duplicated_error option #45

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ovr
Copy link

@ovr ovr commented Feb 28, 2021

Hello!

Thanks

@svenstaro
Copy link
Owner

Shouldn't we perhaps always throw an error in case an artifact with the same name already exists? What do you think?

@ovr
Copy link
Author

ovr commented Mar 12, 2021

Shouldn't we perhaps always throw an error in case an artifact with the same name already exists? What do you think?

GitHub doesn't give an ability to restart specific jobs in a workflow, it's why the whole workflow with all jobs can be restarted. In this case, I am getting a problem with this error, because I have jobs that depend on the job that failed.

Let's imagine

Jobs (step1) -> Job2.1 (step2) -> Job (step3)
                      -> Job2.2 (step2)

For example Job 2.1 success (uploaded artifact), but Job 2.1 failed
I will try to restart the whole workflow and job 2.1 will be failed because it already uploads an artifact

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants