Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-26: Fixed ignored release_name option. #27

Merged
merged 1 commit into from
Sep 25, 2020

Conversation

kittaakos
Copy link
Contributor

name should be used when creating a new release.

Signed-off-by: Akos Kitta kittaakos@typefox.io


What it does:

  • This PR fixes the ignored repo_name property when creating a new GH release: repo_name was incorrectly used instead of name. [Closes release_name does not seem to apply #26]
  • Also, I committed the generated package-lock.json file with the desired 2.1.0 version.

PoC:

@svenstaro can you please review the changes? Thank you!

`name` should be used when creating a new release.

Signed-off-by: Akos Kitta <kittaakos@typefox.io>
@svenstaro svenstaro merged commit 54a6699 into svenstaro:master Sep 25, 2020
@svenstaro
Copy link
Owner

Thanks, looking great! Sorry for taking so long on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

release_name does not seem to apply
2 participants