Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove orphan pluralizations #1017

Merged
merged 7 commits into from
Aug 23, 2022
Merged

Remove orphan pluralizations #1017

merged 7 commits into from
Aug 23, 2022

Commits on Aug 17, 2022

  1. Create a CheckLocales utility class 

    Enables the same code to be used in thor and rspec
    @digitalfrost
    digitalfrost committed Aug 17, 2022
    Configuration menu
    Copy the full SHA
    3223e7a View commit details
    Browse the repository at this point in the history

  2. Add rspec test to check for orphaned pluralization files 

    Check that they are no pluralization files that do not
have a corresponding locale.yml file

Also enabled both Rspec should and expect syntax
    @digitalfrost
    digitalfrost committed Aug 17, 2022
    Configuration menu
    Copy the full SHA
    97149bc View commit details
    Browse the repository at this point in the history

  3. Rename orphaned_plurlizations to orphan_pluralizations

    @digitalfrost
    digitalfrost committed Aug 17, 2022
    Configuration menu
    Copy the full SHA
    fa5d279 View commit details
    Browse the repository at this point in the history

  4. Delete orphan pluralizations 

    Deleted 48 orphan pluralizations that do not have a corresponding
locale file.
    @digitalfrost
    digitalfrost committed Aug 17, 2022
    Configuration menu
    Copy the full SHA
    13a780a View commit details
    Browse the repository at this point in the history

  5. Remove pluralization specs for orphan pluralizations 

    Remove pluralization specs for orphan pluralizations
since these pluralizations have been deleted
    @digitalfrost
    digitalfrost committed Aug 17, 2022
    Configuration menu
    Copy the full SHA
    5bd3194 View commit details
    Browse the repository at this point in the history

  6. Remove thor task that was used to delete orphan pluralizations 

    Existing orphans have been deleted.
The CI should fail if new orphans are added.
    @digitalfrost
    digitalfrost committed Aug 17, 2022
    Configuration menu
    Copy the full SHA
    c2d9b39 View commit details
    Browse the repository at this point in the history

  7. Document removal of pluralizations 

    Added list of removed pluralizations to the README.
    @digitalfrost
    digitalfrost committed Aug 17, 2022
    Configuration menu
    Copy the full SHA
    d619ef3 View commit details
    Browse the repository at this point in the history