Keep the translation missing message when default is not nil #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Edouard-chin
approved these changes
Oct 27, 2017
|
Thank you @rafaelfranca and @Edouard-chin ❤️ This patch looks good to me. Could you please rebase this PR on top of the latest master? Master contains #390, which should fix some of your broken Travis tests (I hope 🤞 ) |
rafaelfranca
force-pushed
the
fix-default-regression
branch
from
ad445f8
to
0efd34f
Compare
|
Done! |
|
Thanks! Travis is still broken though. Let me take a look... 🤔 |
|
Looks related to |
When either the key and the all the defaults have missing translation we should be showing the original key in the translation missing message. Before this commit we were showing a translation missing error in the "no key" key. This commit fixes a regression introduced in ruby-i18n#387.
radar
force-pushed
the
fix-default-regression
branch
from
0efd34f
to
4104295
Compare
|
I've just rebased your branch on top of master. This should fix the Travis build and then we should be good to |
!
|
Thanks! It is green now. |
|
It sure is! ❤️ |
|
v0.9.1 has just been released which contains this fix, as well as #390. Thank you for the attentiveness to this PR. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When either the key and the all the defaults have missing translation we should be showing the original key in the translation missing message.
Before this commit we were showing a translation missing error in the "no key" key.
This commit fixes a regression introduced in #387.