New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keep the translation missing message when default is not nil #389
Conversation
Thank you @rafaelfranca and @Edouard-chin ❤️ This patch looks good to me. Could you please rebase this PR on top of the latest master? Master contains #390, which should fix some of your broken Travis tests (I hope 🤞 ) |
ad445f8
to
0efd34f
Compare
Done! |
Thanks! Travis is still broken though. Let me take a look... 🤔 |
Looks related to |
When either the key and the all the defaults have missing translation we should be showing the original key in the translation missing message. Before this commit we were showing a translation missing error in the "no key" key. This commit fixes a regression introduced in ruby-i18n#387.
0efd34f
to
4104295
Compare
I've just rebased your branch on top of master. This should fix the Travis build and then we should be good to ! |
Thanks! It is green now. |
It sure is! ❤️ |
v0.9.1 has just been released which contains this fix, as well as #390. Thank you for the attentiveness to this PR. |
Thanks! |
When either the key and the all the defaults have missing translation we should be showing the original key in the translation missing message.
Before this commit we were showing a translation missing error in the "no key" key.
This commit fixes a regression introduced in #387.