feat: svelte inspector updates and promote from experimental #631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t getting removed by something overwriting body content
|
@delight sorry it took so long and i incorporated your PRs into this one as there was a fair bit of shifting around. I would love to get your review/feedback on this. |
This was referenced Apr 24, 2023
|
After discussing with svelte maintainers, inspector is not going to be enabled by default in vite-plugin-svelte as there can be situations where it is not useful and vite-plugin-svelte is a general purpose plugin. It might be enabled by default in a future version of sveltekit though. |
5 tasks
bluwy
reviewed
Apr 27, 2023
bluwy
approved these changes
Apr 27, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have received some Feedback for svelte-inspector and this PR aims to address most of it.
Adresses open issues and PRs:
fixes #434 by moving inspector ui outside of
<body>fixes #518 by automatically disabling inspector when user leaves the browser window after opening a file
fixes #551 by prepending configured base path to __openInEditor request
fixes #555 by changing default combo on linux to control-shift
fixes #559 by enabling holdMode by default
New Feature: Set options via environment.
No longer experimental
Move your inspector config to the root of
vitePlugin.// svelte.config.js export default { vitePlugin:{ experimental:{ - inspector: {...} }, + inspector: {...} } }