Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use new values for compilerOptions.css with svelte 3.53+ #490

Merged
merged 8 commits into from
Nov 11, 2022
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/popular-oranges-warn.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@sveltejs/vite-plugin-svelte': minor
---

support string values of compilerOptions.css added in svelte 3.53.0
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@
"prettier": "^2.7.1",
"prettier-plugin-svelte": "^2.8.0",
"rimraf": "^3.0.2",
"svelte": "^3.52.0",
"svelte": "^3.53.0",
"typescript": "^4.8.4",
"vite": "^3.2.3",
"vitest": "^0.25.0"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,14 +8,14 @@
"package.json",
"index.js"
],
"exports":{
"exports": {
".": {
"import": "./index.js"
},
"./package.json": "./package.json"
},
"type": "module",
"dependencies": {
"svelte": "^3.52.0"
"svelte": "^3.53.0"
}
}
2 changes: 1 addition & 1 deletion packages/e2e-tests/autoprefixer-browerslist/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
"autoprefixer": "^10.4.13",
"postcss": "^8.4.18",
"postcss-load-config": "^4.0.1",
"svelte": "^3.52.0",
"svelte": "^3.53.0",
"svelte-preprocess": "^4.10.7",
"vite": "^3.2.3"
},
Expand Down
2 changes: 1 addition & 1 deletion packages/e2e-tests/configfile-custom/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
},
"devDependencies": {
"@sveltejs/vite-plugin-svelte": "workspace:*",
"svelte": "^3.52.0",
"svelte": "^3.53.0",
"vite": "^3.2.3"
},
"type": "module"
Expand Down
2 changes: 1 addition & 1 deletion packages/e2e-tests/configfile-esm/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
},
"devDependencies": {
"@sveltejs/vite-plugin-svelte": "workspace:*",
"svelte": "^3.52.0",
"svelte": "^3.53.0",
"svelte-preprocess": "^4.10.7",
"vite": "^3.2.3"
},
Expand Down
19 changes: 19 additions & 0 deletions packages/e2e-tests/css-none/__tests__/css-none.spec.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
import { browserLogs, findAssetFile, getColor, getText, isBuild } from '~utils';

test('should not have failed requests', async () => {
browserLogs.forEach((msg) => {
expect(msg).not.toMatch('404');
});
});

test('should not apply component css', async () => {
expect(await getText('#test')).toBe('not red');
expect(await getColor('#test')).not.toBe('red');
});

if (isBuild) {
test('should not output css', async () => {
const css = await findAssetFile(/index.*\.css/);
expect(css).toBe(''); // findAssetFile returns empty for not found
});
}
13 changes: 13 additions & 0 deletions packages/e2e-tests/css-none/index.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
<!DOCTYPE html>
<html lang="en">
<head>
<meta charset="utf-8" />
<meta name="viewport" content="width=device-width,initial-scale=1" />

<title>Svelte app</title>

<script type="module" src="/src/main.js"></script>
</head>

<body></body>
</html>
16 changes: 16 additions & 0 deletions packages/e2e-tests/css-none/package.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
{
"name": "e2e-tests-css-none",
"private": true,
"version": "0.0.0",
"type": "module",
"scripts": {
"dev": "vite",
"build": "vite build",
"preview": "vite preview"
},
"devDependencies": {
"@sveltejs/vite-plugin-svelte": "workspace:*",
"svelte": "^3.53.0",
"vite": "^3.2.3"
}
}
7 changes: 7 additions & 0 deletions packages/e2e-tests/css-none/src/App.svelte
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
<div id="test">not red</div>

<style>
#test {
color: red;
}
</style>
7 changes: 7 additions & 0 deletions packages/e2e-tests/css-none/src/main.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
import App from './App.svelte';

const app = new App({
target: document.body
});

export default app;
2 changes: 2 additions & 0 deletions packages/e2e-tests/css-none/src/vite-env.d.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
/// <reference types="svelte" />
/// <reference types="vite/client" />
7 changes: 7 additions & 0 deletions packages/e2e-tests/css-none/vite.config.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
import { defineConfig } from 'vite';
import { svelte } from '@sveltejs/vite-plugin-svelte';

// https://vitejs.dev/config/
export default defineConfig({
plugins: [svelte({ compilerOptions: { css: 'none' } })]
});
2 changes: 1 addition & 1 deletion packages/e2e-tests/custom-extensions/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
},
"devDependencies": {
"@sveltejs/vite-plugin-svelte": "workspace:*",
"svelte": "^3.52.0",
"svelte": "^3.53.0",
"vite": "^3.2.3"
},
"type": "module"
Expand Down
2 changes: 1 addition & 1 deletion packages/e2e-tests/env/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
},
"devDependencies": {
"@sveltejs/vite-plugin-svelte": "workspace:*",
"svelte": "^3.52.0",
"svelte": "^3.53.0",
"vite": "^3.2.3"
},
"type": "module"
Expand Down
2 changes: 1 addition & 1 deletion packages/e2e-tests/hmr/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"@sveltejs/vite-plugin-svelte": "workspace:*",
"e2e-test-dep-vite-plugins": "workspace:*",
"node-fetch": "^3.2.10",
"svelte": "^3.52.0",
"svelte": "^3.53.0",
"vite": "^3.2.3"
},
"type": "module"
Expand Down
2 changes: 1 addition & 1 deletion packages/e2e-tests/inspector-kit/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
},
"devDependencies": {
"@sveltejs/kit": "^1.0.0-next.538",
"svelte": "^3.52.0",
"svelte": "^3.53.0",
"vite": "^3.2.3"
},
"type": "module"
Expand Down
2 changes: 1 addition & 1 deletion packages/e2e-tests/inspector-vite/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
},
"devDependencies": {
"@sveltejs/vite-plugin-svelte": "workspace:*",
"svelte": "^3.52.0",
"svelte": "^3.53.0",
"vite": "^3.2.3"
}
}
2 changes: 1 addition & 1 deletion packages/e2e-tests/kit-node/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
"@sveltejs/kit": "^1.0.0-next.538",
"e2e-test-dep-svelte-api-only": "file:../_test_dependencies/svelte-api-only",
"e2e-test-dep-vite-plugins": "file:../_test_dependencies/vite-plugins",
"svelte": "^3.52.0",
"svelte": "^3.53.0",
"svelte-check": "^2.9.2",
"svelte-i18n": "^3.4.0",
"tiny-glob": "^0.2.9",
Expand Down
2 changes: 1 addition & 1 deletion packages/e2e-tests/package-json-svelte-field/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
},
"devDependencies": {
"@sveltejs/vite-plugin-svelte": "workspace:*",
"svelte": "^3.52.0",
"svelte": "^3.53.0",
"vite": "^3.2.3"
},
"type": "module"
Expand Down
2 changes: 1 addition & 1 deletion packages/e2e-tests/preprocess-with-vite/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"@sveltejs/vite-plugin-svelte": "workspace:*",
"sass": "^1.56.0",
"stylus": "^0.59.0",
"svelte": "^3.52.0",
"svelte": "^3.53.0",
"vite": "^3.2.3"
},
"type": "commonjs"
Expand Down
2 changes: 1 addition & 1 deletion packages/e2e-tests/svelte-preprocess/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"devDependencies": {
"@sveltejs/vite-plugin-svelte": "workspace:*",
"sass": "^1.56.0",
"svelte": "^3.52.0",
"svelte": "^3.53.0",
"svelte-preprocess": "^4.10.7",
"typescript": "^4.8.4",
"vite": "^3.2.3"
Expand Down
2 changes: 1 addition & 1 deletion packages/e2e-tests/ts-type-import/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"@sveltejs/vite-plugin-svelte": "workspace:*",
"@tsconfig/svelte": "^3.0.0",
"@types/node": "^18.11.9",
"svelte": "^3.52.0",
"svelte": "^3.53.0",
"svelte-preprocess": "^4.10.7",
"vite": "^3.2.3"
},
Expand Down
2 changes: 1 addition & 1 deletion packages/e2e-tests/vite-ssr-esm/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
"express": "^4.18.2",
"npm-run-all": "^4.1.5",
"serve-static": "^1.15.0",
"svelte": "^3.52.0",
"svelte": "^3.53.0",
"vite": "^3.2.3"
}
}
2 changes: 1 addition & 1 deletion packages/e2e-tests/vite-ssr/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"e2e-test-dep-esm-only": "workspace:*",
"express": "^4.18.2",
"serve-static": "^1.15.0",
"svelte": "^3.52.0",
"svelte": "^3.53.0",
"vite": "^3.2.3"
}
}
2 changes: 1 addition & 1 deletion packages/playground/big-component-library/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"devDependencies": {
"@sveltejs/vite-plugin-svelte": "workspace:*",
"carbon-components-svelte": "^0.70.12",
"svelte": "^3.52.0",
"svelte": "^3.53.0",
"vite": "^3.2.3"
},
"dependencies": {
Expand Down
2 changes: 1 addition & 1 deletion packages/playground/big/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
},
"devDependencies": {
"@sveltejs/vite-plugin-svelte": "workspace:*",
"svelte": "^3.52.0",
"svelte": "^3.53.0",
"vite": "^3.2.3"
}
}
2 changes: 1 addition & 1 deletion packages/playground/kit-demo-app/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
"@sveltejs/adapter-auto": "^1.0.0-next.87",
"@sveltejs/kit": "^1.0.0-next.538",
"@types/cookie": "^0.5.1",
"svelte": "^3.52.0",
"svelte": "^3.53.0",
"svelte-check": "^2.9.2",
"typescript": "^4.8.4",
"vite": "^3.2.3"
Expand Down
2 changes: 1 addition & 1 deletion packages/playground/optimizedeps-include/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
},
"devDependencies": {
"@sveltejs/vite-plugin-svelte": "workspace:*",
"svelte": "^3.52.0",
"svelte": "^3.53.0",
"tinro": "^0.6.12",
"vite": "^3.2.3"
}
Expand Down
2 changes: 1 addition & 1 deletion packages/playground/windicss/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
"devDependencies": {
"@sveltejs/vite-plugin-svelte": "workspace:*",
"diff-match-patch": "^1.0.5",
"svelte": "^3.52.0",
"svelte": "^3.53.0",
"vite": "^3.2.3",
"vite-plugin-windicss": "^1.8.8"
}
Expand Down
2 changes: 1 addition & 1 deletion packages/vite-plugin-svelte/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@
"diff-match-patch": "^1.0.5",
"esbuild": "^0.15.13",
"rollup": "^2.79.1",
"svelte": "^3.52.0",
"svelte": "^3.53.0",
"tsup": "^6.4.0",
"vite": "^3.2.3"
}
Expand Down