feat: correctly prebundle svelte libraries #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluwy
commented
Mar 30, 2022
dominikg
reviewed
Mar 30, 2022
dominikg
reviewed
Mar 30, 2022
dominikg
reviewed
Mar 30, 2022
dominikg
approved these changes
Apr 2, 2022
|
Merging this in so we don't hold it any longer. Summary: There's one more thing to do to make sure we can force reoptimization of the dev server without a hack. |
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires Vite 2.9,
though I think it works with Vite 2.8 too (with caveats), but may be better to still bump the peer dep. Putting this here for visibility and if others like to try.Closes #222