Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove svelte css transform #280

Merged
merged 6 commits into from
Feb 26, 2022
Merged

fix: remove svelte css transform #280

merged 6 commits into from
Feb 26, 2022

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Feb 26, 2022

Fixes sveltejs/kit#4125

I can't seem to transfer it over to this repo. GitHub seems to have issues.

@dominikg
Copy link
Member

i tried to do this locally yesterday but had some issues testing that it works as expected.

Ideally we'd add an e2e test that adds 3 transform plugins (pre, regular, post) that do both css and js transforms to a test svelte component and see that they all actually do work.
In addition to a regular vite+svelte setup a similar test for sveltekit may be needed too.

In a broader sense i wonder if there is a way to build a testsuite to validate that vite plugins behave per spec.

@bluwy
Copy link
Member Author

bluwy commented Feb 26, 2022

I actually haven't tested this in a vite/sveltekit project, so adding a test case for this would be a great idea 😄 I can try a transform test for that.

@bluwy
Copy link
Member Author

bluwy commented Feb 26, 2022

Added vite plugin tests for the hmr and kit-node e2e tests. All seems to be working fine now.

In a broader sense i wonder if there is a way to build a testsuite to validate that vite plugins behave per spec.

I think VIte has the potential for testing those explicitly in the plugin container spec file, but it's not a lot of coverage right now. The e2e tests sort-of close the gap over time.

@bluwy bluwy merged commit 35acec8 into main Feb 26, 2022
@bluwy bluwy deleted the fix-transform-handling branch February 26, 2022 18:36
@github-actions github-actions bot mentioned this pull request Feb 26, 2022
@github-actions github-actions bot mentioned this pull request Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't apply css transform using other vite plugin
2 participants