Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throws warnings with Svelte 3.53.0 #489

Closed
patoi opened this issue Nov 10, 2022 · 2 comments · Fixed by #490 or nornagon/cdda-guide#134
Closed

Throws warnings with Svelte 3.53.0 #489

patoi opened this issue Nov 10, 2022 · 2 comments · Fixed by #490 or nornagon/cdda-guide#134
Labels
bug Something isn't working

Comments

@patoi
Copy link

patoi commented Nov 10, 2022

Describe the bug

Throws warnings with Svelte 3.53.0: "options.css as a boolean is deprecated. Use 'external' instead of false."

9:46:34 AM [vite-plugin-svelte] /<repo>/node_modules/.pnpm/carbon-components-svelte@0.70.12/node_modules/carbon-components-svelte/src/icons/Information.svelte options.css as a boolean is deprecated. Use 'external' instead of false.

https://github.com/sveltejs/svelte/blob/master/CHANGELOG.md#3530 changelog:

Extend css compiler option with 'external' | 'injected' | 'none' settings and deprecate old true | false values (sveltejs/svelte#7914)

Reproduction URL

Reproduction

No response

Logs

9:46:34 AM [vite-plugin-svelte] /<repo>/node_modules/.pnpm/carbon-components-svelte@0.70.12/node_modules/carbon-components-svelte/src/icons/Information.svelte options.css as a boolean is deprecated. Use 'external' instead of false.

System Info

not relevant
@patoi patoi added bug Something isn't working triage Awaiting triage by a project member labels Nov 10, 2022
@dominikg dominikg removed the triage Awaiting triage by a project member label Nov 10, 2022
@dominikg
Copy link
Member

dominikg commented Nov 10, 2022

from the PR that introduced it 'injected' (formerly true) and 'external' (formerly false) you should be able to work around it by explicitly setting it to external in your config until v-p-s released a new version that does it by default

update to svelte 3.53.1 , the above did not work

@dominikg
Copy link
Member

the warning is removed in svelte 3.53.1, update to get rid of it.

this will remain open until #490 is merged bc technically v-p-s is still providing outdated config defaults.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants