Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: fix out-of-box problems #134

Merged
merged 5 commits into from May 2, 2023
Merged

build: fix out-of-box problems #134

merged 5 commits into from May 2, 2023

Conversation

scarf005
Copy link
Contributor

Summary

  • added workbox-window
  • bumped svelte to 3.58.0

Rationale

nornagon
nornagon reviewed May 2, 2023
View reviewed changes
package.json Outdated Show resolved Hide resolved
@nornagon
Copy link
Owner

nornagon commented May 2, 2023

looks like the lockfile needs to be updated too. mind running yarn and adding yarn.lock to the PR?

@nornagon nornagon merged commit 628668b into nornagon:main May 2, 2023
1 check passed
@scarf005 scarf005 deleted the dev-fix branch May 2, 2023 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nornagon nornagon nornagon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Throws warnings with Svelte 3.53.0 workbox-window not installed by pnpm
2 participants
@scarf005 @nornagon