-
-
Notifications
You must be signed in to change notification settings - Fork 98
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: add svelte lib without components to noExternal (#166)
* chore: add test * fix: add svelte lib without components to noExternal * chore: update test * chore: add changeset * perf(dependencies): better svelte lib check
- Loading branch information
Showing
9 changed files
with
65 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
'@sveltejs/vite-plugin-svelte': patch | ||
--- | ||
|
||
Svelte libraries without any Svelte components are also added to ssr.noExternal |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,7 +6,7 @@ | |
"module": "index.js", | ||
"files": [ | ||
"package.json", | ||
"index.cjs" | ||
"index.js" | ||
], | ||
"exports":{ | ||
".": { | ||
|
5 changes: 5 additions & 0 deletions
5
packages/e2e-tests/_test_dependencies/svelte-api-only/index.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
import { setContext } from 'svelte'; | ||
|
||
export function setSomeContext() { | ||
setContext('svelte-api-only', true); | ||
} |
18 changes: 18 additions & 0 deletions
18
packages/e2e-tests/_test_dependencies/svelte-api-only/package.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
{ | ||
"version": "1.0.0", | ||
"private": true, | ||
"name": "e2e-test-dep-svelte-api-only", | ||
"main": "index.js", | ||
"module": "index.js", | ||
"files": [ | ||
"package.json", | ||
"index.js" | ||
], | ||
"exports":{ | ||
".": { | ||
"import": "./index.js" | ||
}, | ||
"./package.json": "./package.json" | ||
}, | ||
"type": "module" | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.