Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] don't emit deprecation warning for now #8012

Merged
merged 5 commits into from Nov 10, 2022
Merged

[fix] don't emit deprecation warning for now #8012

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
189d9c8
[fix] emit deprecation warning only once
dummdidumm Nov 10, 2022
11a32ef
omit deprecation warning completely for now
dummdidumm Nov 10, 2022
7c9b001
update changelog
dummdidumm Nov 10, 2022
e282767
update changelog
Conduitry Nov 10, 2022
5f0ef3d
update changelog
Conduitry Nov 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
@@ -1,5 +1,9 @@
# Svelte changelog

## Unreleased

* Do not emit deprecation warnings for `css` compiler options for now ([#8009](https://github.com/sveltejs/svelte/issues/8009))

## 3.53.0

* Check whether `parentNode` exists before removing child ([#6037](https://github.com/sveltejs/svelte/issues/6037))
Expand Down
16 changes: 9 additions & 7 deletions src/compiler/compile/index.ts
View file
Open in desktop
Expand Up @@ -89,13 +89,15 @@ function validate_options(options: CompileOptions, warnings: Warning[]) {

if (css === true || css === false) {
options.css = css === true ? 'injected' : 'external';
const message = `options.css as a boolean is deprecated. Use '${options.css}' instead of ${css}.`;
warnings.push({
code: 'options-css-boolean-deprecated',
message,
filename,
toString: () => message
});
// possibly show this warning once we decided how Svelte 4 looks like
// const message = `options.css as a boolean is deprecated. Use '${options.css}' instead of ${css}.`;
// warnings.push({
// code: 'options-css-boolean-deprecated',
// message,
// filename,
// toString: () => message
// });
// }
}

if (namespace && valid_namespaces.indexOf(namespace) === -1) {
Expand Down