Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: slot binding on inner element read error in arrow function #7667

Merged
merged 4 commits into from Jul 28, 2022

Conversation

magentaqin
Copy link
Contributor

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with [feat], [fix], [chore], or [docs].
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with npm test and lint the project with npm run lint

Description

Related #7485
As I commented in this issue, the root reason is not about named slot or default slot. The root reason of the bug is let binding on inner fragment element can not read in arrow function.

Copy link
Member

@tanhauhau tanhauhau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I've moved the test from parser test, which just test if it can parse the code correctly, to a runtime test, which test if the component works as expected after being compiled without errors, asserting that the innerCall function works as expected

@magentaqin
Copy link
Contributor Author

@tanhauhau Thanks for adding runtime test! Still, I think runtime and parser test are both necessary, as this bug is at compiler stage and will throw error when running npm run build.

@tanhauhau
Copy link
Member

@tanhauhau Thanks for adding runtime test! Still, I think runtime and parser test are both necessary, as this bug is at compiler stage and will throw error when running npm run build.

if the component build could not be build, the runtime test would failed too.

@magentaqin
Copy link
Contributor Author

@tanhauhau Thanks for adding runtime test! Still, I think runtime and parser test are both necessary, as this bug is at compiler stage and will throw error when running npm run build.

if the component build could not be build, the runtime test would failed too.

Got it.

@magentaqin
Copy link
Contributor Author

@tanhauhau I notice this PR has been approved but not merged. Is this PR any merging problem?

@dummdidumm dummdidumm merged commit 5dd703f into sveltejs:master Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants