Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Apply class directive for <svelte:element> properly #7531

Merged
merged 1 commit into from May 18, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/compiler/compile/render_dom/wrappers/Element/index.ts
Expand Up @@ -1048,7 +1048,7 @@ export default class ElementWrapper extends Wrapper {

block.chunks.hydrate.push(updater);

if (has_spread) {
if (has_spread || this.node.is_dynamic_element) {
block.chunks.update.push(updater);
} else if ((dependencies && dependencies.size > 0) || this.class_dependencies.length) {
const all_dependencies = this.class_dependencies.concat(...dependencies);
Expand Down
13 changes: 13 additions & 0 deletions test/runtime/samples/dynamic-element-class-directive/Link.svelte
@@ -0,0 +1,13 @@
<script>
export let item;
</script>

<svelte:element this="div" class:active={true}>
{item.text}
</svelte:element>

<style>
.active {
color: red;
}
</style>
11 changes: 11 additions & 0 deletions test/runtime/samples/dynamic-element-class-directive/_config.js
@@ -0,0 +1,11 @@
export default {
html: `
<div class="svelte-1vsuzn0 active">foo</div>
<div class="svelte-1vsuzn0 active">foo0</div>
<div class="svelte-1vsuzn0 active">foo0</div>
<div class="svelte-1vsuzn0 active">foo0</div>
<div class="svelte-1vsuzn0 active">foo1</div>
<div class="svelte-1vsuzn0 active">foo2</div>
<div class="svelte-1vsuzn0 active">foo3</div>
`
};
16 changes: 16 additions & 0 deletions test/runtime/samples/dynamic-element-class-directive/main.svelte
@@ -0,0 +1,16 @@
<script>
import Link from "./Link.svelte";
let foo = [
{ text: "foo0" },
{ text: "foo1" },
{ text: "foo2" },
{ text: "foo3" },
];
</script>

<Link item={{ text: "foo" }} />
<Link item={foo[0]} />
<Link bind:item={foo[0]} />
{#each foo as item}
<Link bind:item />
{/each}