Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] always use set_attributes for attribute of <svelte:element> #7486

Merged
merged 2 commits into from Apr 30, 2022
Merged

[fix] always use set_attributes for attribute of <svelte:element> #7486

merged 2 commits into from Apr 30, 2022

Conversation

baseballyama
Copy link
Member

fix: #7478

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with [feat], [fix], [chore], or [docs].
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with npm test and lint the project with npm run lint

@Conduitry Conduitry merged commit 1f1750e into sveltejs:master Apr 30, 2022
himanshiLt pushed a commit to himanshiLt/svelte that referenced this pull request Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

svelte:element Boolean Attributes don't get handled like propper elements (disabled="false")
3 participants