Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Specify svg namespace if {@html} is used in svg #7464

Merged
merged 3 commits into from Apr 19, 2022
Merged

[fix] Specify svg namespace if {@html} is used in svg #7464

merged 3 commits into from Apr 19, 2022

Conversation

baseballyama
Copy link
Member

fix: #7450, #7002

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with [feat], [fix], [chore], or [docs].
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with npm test and lint the project with npm run lint

@dimfeld
Copy link
Contributor

dimfeld commented Apr 16, 2022

Nice! I believe this fixes #5764 as well.

@baseballyama
Copy link
Member Author

Oh, I didn't know #5764.
And unfortunately, now this PR doesn't handle it.

I just quick look this, but for handling, I think we need to check parent element is SVG or not at mount function in runtime.
I think this would require a hack of the life cycle. If this is correct, I think we should defer to handling this until we know this is a major use case.

@baseballyama
Copy link
Member Author

@tanhauhau

Thank you for your review!
Regarding lint, I created a new PR.
#7466

dont see much benefit for differentiating claim_svg_tag and claim_html_tag, can just do

I updated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SVG @html element not rentering from string
3 participants