Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] rendering void tag for <svelte:element> #7453

Merged
merged 11 commits into from Apr 30, 2022
Merged

[fix] rendering void tag for <svelte:element> #7453

merged 11 commits into from Apr 30, 2022

Conversation

baseballyama
Copy link
Member

fix: #7449

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with [feat], [fix], [chore], or [docs].
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with npm test and lint the project with npm run lint

test/runtime/index.ts Outdated Show resolved Hide resolved
test/runtime/index.ts Outdated Show resolved Hide resolved
test/runtime/samples/dynamic-element-string/_config.js Outdated Show resolved Hide resolved
test/runtime/samples/dynamic-element-void-tag/_config.js Outdated Show resolved Hide resolved
src/compiler/compile/render_ssr/handlers/Element.ts Outdated Show resolved Hide resolved
src/compiler/utils/names.ts Show resolved Hide resolved
@tanhauhau
Copy link
Member

@baseballyama usually when there's new commit on the master branch, I dont merge master into my branch, instead i rebase my branch onto the latest master branch. This allows me to have a cleaner, linear history on the branch, and allowing me to squash all the changes during merging the PR.

@baseballyama
Copy link
Member Author

OK, I will use rebase on Svelte repository.

Since now I did not use rebasing on Svelte after starting PR, because it become unable to know where is a new change, and I felt that merging was often used in sveltejs repositories.

@baseballyama
Copy link
Member Author

@tanhauhau

Thank you for updating it!

@baseballyama
Copy link
Member Author

I rebased it on master branch because conflict is there.

@Conduitry Conduitry merged commit 0d017f4 into sveltejs:master Apr 30, 2022
himanshiLt pushed a commit to himanshiLt/svelte that referenced this pull request Jun 24, 2022
@baseballyama baseballyama deleted the fix/7449 branch September 4, 2022 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New svelte:element tag does not handle void tags correctly
4 participants