Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] add <svelte:element> example #7439

Merged
merged 1 commit into from Apr 10, 2022

Conversation

oekazuma
Copy link
Contributor

@oekazuma oekazuma commented Apr 9, 2022

Add example of <svelte:element> added at #6898

Before submitting the PR, please make sure you do the following

  • Prefix your PR title with [feat], [fix], [chore], or [docs].
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with npm test and lint the project with npm run lint

@tanhauhau tanhauhau merged commit 707455f into sveltejs:master Apr 10, 2022
@lukaszpolowczyk
Copy link

@oekazuma This thumbnail link does not work:
https://svelte.dev/examples/thumbnails/svelte-element.jpg

This is what it looks like in https://svelte.dev/examples/svelte-element:
obraz

@oekazuma
Copy link
Contributor Author

@lukaszpolowczyk
Thanks for the report.

@tanhauhau @dummdidumm
I do not know how to add thumbnails.
Can you please tell me how to do this?

@tanhauhau
Copy link
Member

hmm.. i think the thumbnail currently lives in https://github.com/sveltejs/sites/tree/master/sites/svelte.dev/static/examples/thumbnails

create a jpg file named the same as the url slug name, eg: svelte-element.jpg

@oekazuma
Copy link
Contributor Author

oekazuma commented Apr 11, 2022

Thanks!
I will submit a Pull Request with sveltejs/sites

sveltejs/sites#324

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants