Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat] Make setContext return the value that was passed in #7432

Merged
merged 6 commits into from Apr 11, 2022
Merged

[feat] Make setContext return the value that was passed in #7432

merged 6 commits into from Apr 11, 2022

Conversation

gtm-nayan
Copy link
Contributor

@gtm-nayan gtm-nayan commented Apr 8, 2022 •
edited

Fixes #7427

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with [feat], [fix], [chore], or [docs].
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with npm test and lint the project with npm run lint

3 are failing but they are failing without the change too, so this PR shouldn't be the cause. (nvm idk what was up with that on my machine)

tanhauhau
tanhauhau reviewed Apr 9, 2022
View reviewed changes
Copy link
Member

@tanhauhau tanhauhau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about a test case to test the returned value of setContext?

@gtm-nayan
Copy link
Contributor Author

@tanhauhau done

@tanhauhau tanhauhau merged commit afd3f4e into sveltejs:master Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanhauhau tanhauhau tanhauhau approved these changes

@bluwy bluwy bluwy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make setContext return the value that was just set.
3 participants
@gtm-nayan @tanhauhau @bluwy