[fix] style shorthand lost in production mode #7390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also a minor variable rename because it bugged me.
This was referenced Oct 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #7386 for context, but essentially elements using the
style:<prop>shorthand are not generating an update function in production mode due to theinnerHTMLoptimization being applied incorrectly.So this fixes #7386 by adding a new condition to check for when opting out of the
.innerHTMLoptimization in prod mode. Also modifies an existing test so that it'll demonstrate the bug and fail without the logic fix.Huge thanks to @dummdidumm for pointing to literally the exact line that needed changing.