Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] Adds aria-description to aria_attributes - #7301 #7302

Merged
merged 2 commits into from Feb 22, 2022
Merged

[fix] Adds aria-description to aria_attributes - #7301 #7302

merged 2 commits into from Feb 22, 2022

Conversation

stordahl
Copy link
Contributor

@stordahl stordahl commented Feb 22, 2022 •
edited

This PR simply adds aria-description to the list of allowed ARIA attributes. Find more info about aria-description here. Fixes #7301.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with [feat], [fix], [chore], or [docs].
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with npm test and lint the project with npm run lint

@dummdidumm dummdidumm merged commit b6441eb into sveltejs:master Feb 22, 2022
himanshiLt pushed a commit to himanshiLt/svelte that referenced this pull request Mar 3, 2022
@stordahl @himanshiLt
[fix] add aria-description aria_attributes - (sveltejs#7302)
6807849 
Fixes sveltejs#7301
nevilm-lt pushed a commit to nevilm-lt/svelte that referenced this pull request Mar 14, 2022
@stordahl @nevilm-lt
[fix] add aria-description aria_attributes - (sveltejs#7302)
aa835d0 
Fixes sveltejs#7301
nevilm-lt pushed a commit to nevilm-lt/svelte that referenced this pull request Apr 21, 2022
@stordahl @nevilm-lt
[fix] add aria-description aria_attributes - (sveltejs#7302)
8c68ae8 
Fixes sveltejs#7301
nevilm-lt pushed a commit to nevilm-lt/svelte that referenced this pull request Apr 21, 2022
@stordahl @nevilm-lt
[fix] add aria-description aria_attributes - (sveltejs#7302)
bd7ea7b 
Fixes sveltejs#7301
nevilm-lt pushed a commit to nevilm-lt/svelte that referenced this pull request Apr 22, 2022
@stordahl @nevilm-lt
[fix] add aria-description aria_attributes - (sveltejs#7302)
b765b6b 
Fixes sveltejs#7301
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoffrich geoffrich geoffrich approved these changes

@bluwy bluwy bluwy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add aria-description to a11y linting
4 participants
@stordahl @geoffrich @bluwy @dummdidumm