Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recursively check label children for input control #5323

Merged
merged 4 commits into from Aug 8, 2022

Conversation

nsimonson
Copy link
Contributor

@nsimonson nsimonson commented Aug 29, 2020

a11y-label-has-associated-control was only checking direct children. This would cause a false positive when the label was abstracted to a component or the input control was nested in other tags.

Fixes #5300
Fixes #5528

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with npm test and lint the project with npm run lint

@sahinf
Copy link

sahinf commented Jun 3, 2022

Will this fix be merged anytime?

@tanhauhau
Copy link
Member

Related #6442

@tanhauhau tanhauhau merged commit 419641b into sveltejs:master Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler Changes relating to the compiler
Projects
None yet
5 participants