WIP fix for #4731: preserveWhitespace in SSR #4737
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP fix for #4731.
Why this is still work in progress:
the test works, but don't currently fail, becausehtmlEqual
usesnormalizeHtml
which strips spaces & comments (same problem as Fix perserveComments on ssr (#4730) #4736), any advise?Update: solved by updating the testing code in #f2e0479
_actual.html
, but are in working with full samples, what am I missing?option
in{#each}
-loop still don't preserve whitespace (was looking atshould_skip
insrc/compiler/compile/render_dom/wrappers/Text.ts
)Update: both open issues seem to be related to
should_skip
insrc/compiler/compile/nodes/Text.ts
, for some reason this check doesn't work (preserveWhitespace
seems to be false):