Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP fix for #4731: preserveWhitespace in SSR #4737

Closed

Conversation

bwbroersma
Copy link
Contributor

@bwbroersma bwbroersma commented Apr 28, 2020

WIP fix for #4731.

Why this is still work in progress:

Update: both open issues seem to be related to should_skip in src/compiler/compile/nodes/Text.ts, for some reason this check doesn't work (preserveWhitespace seems to be false):

		return parent_element.namespace
			|| elements_without_text.has(parent_element.name)
			&& (this.component.compile_options.preserveWhitespace
				|| this.component.component_options.preserveWhitespace);

@Conduitry Conduitry marked this pull request as draft April 29, 2020 21:29
@stale
Copy link

stale bot commented Jun 26, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale-bot label Jun 26, 2021
@stale stale bot removed the stale-bot label Jun 26, 2021
@stale stale bot removed the stale-bot label Jun 27, 2021
@dummdidumm dummdidumm closed this in 7463d51 Feb 2, 2022
himanshiLt pushed a commit to himanshiLt/svelte that referenced this pull request Mar 3, 2022
…tejs#6990)

Fixes sveltejs#6437
Fixes sveltejs#4731
Closes sveltejs#4737

Whitespace is now untouched inside <pre> tag and other tags if preserveWhitespace is true
nevilm-lt pushed a commit to nevilm-lt/svelte that referenced this pull request Mar 14, 2022
…tejs#6990)

Fixes sveltejs#6437
Fixes sveltejs#4731
Closes sveltejs#4737

Whitespace is now untouched inside <pre> tag and other tags if preserveWhitespace is true
nevilm-lt pushed a commit to nevilm-lt/svelte that referenced this pull request Apr 21, 2022
…tejs#6990)

Fixes sveltejs#6437
Fixes sveltejs#4731
Closes sveltejs#4737

Whitespace is now untouched inside <pre> tag and other tags if preserveWhitespace is true
nevilm-lt pushed a commit to nevilm-lt/svelte that referenced this pull request Apr 21, 2022
…tejs#6990)

Fixes sveltejs#6437
Fixes sveltejs#4731
Closes sveltejs#4737

Whitespace is now untouched inside <pre> tag and other tags if preserveWhitespace is true
nevilm-lt pushed a commit to nevilm-lt/svelte that referenced this pull request Apr 22, 2022
…tejs#6990)

Fixes sveltejs#6437
Fixes sveltejs#4731
Closes sveltejs#4737

Whitespace is now untouched inside <pre> tag and other tags if preserveWhitespace is true
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants