New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3187 check-parent-node-when-detaching #3188

Closed

matyunya wants to merge 1 commit into sveltejs:master from matyunya:detaching

matyunya commented Jul 6, 2019 •

edited

This fix problem when parent node is null while detaching. Same problem spotted in Sapper in the same function:
sveltejs/sapper-template#158


          3187 check-parent-node-when-detaching

a5420ad

GottZ approved these changes

View reviewed changes

evdama mentioned this pull request

Fix for detaching meta in <svelte:head> sveltejs/sapper#793

Closed

Conduitry mentioned this pull request

No parent node when detaching #3187

Closed

Member

Conduitry commented Jul 6, 2019

#3172 hasn't been merged yet, but it does seem to also fix the Svelte issue this was intended to address. Closing.

Conduitry closed this

DuplicatePR-bot mentioned this pull request

Avoid an error on double detaching a node #3736

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment