Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Realistic spring behavior at low framerates #11337

Open
wants to merge 1 commit into
base: svelte-4
Choose a base branch
from

Conversation

JuchokJuk
Copy link

Fix for bug described here: #7010

This is a fix for a bug caused by too long deltaTime between requestAnimationFrame callbacks; the spring physics calculation is not designed for such a long “prediction”. Since requestAnimationFrame does not fire callback while the page tab is invisible or the cpu is heavily loaded, deltaTime becomes too large.

I added deltaTime limit to 24fps

Copy link

changeset-bot bot commented Apr 25, 2024

⚠️ No Changeset found

Latest commit: 23cbc8f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant