Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement message overloads #11318

Merged
merged 1 commit into from Apr 24, 2024
Merged

feat: implement message overloads #11318

merged 1 commit into from Apr 24, 2024

Conversation

Rich-Harris
Copy link
Member

See #11305.

This makes it possible for an error/warning message to have multiple variants, to satisfy the common pattern of appending 'Did you mean %suggestion%?' with incorrect bindings etc, without needing multiple codes for what is essentially the same issue.

It also adds the ability have a separate prose section, which isn't currently used anywhere but can be in future:

## error_code

> Incorrect thing %thing%

> Incorrect thing %thing%. Did you mean %suggestion%?

Here is a longer explanation of this thing.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Apr 24, 2024

⚠️ No Changeset found

Latest commit: 14a5260

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Rich-Harris Rich-Harris merged commit 6ad5cd4 into main Apr 24, 2024
8 checks passed
@Rich-Harris Rich-Harris deleted the message-overloads branch April 24, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant