Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace unpkg with jsdelivr #10748

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: replace unpkg with jsdelivr #10748

wants to merge 1 commit into from

Conversation

Rich-Harris
Copy link
Member

I've found unpkg to be a bit flaky lately. It's completely unmaintained (last commit was three years ago). We should just use jsdelivr instead

Copy link

changeset-bot bot commented Mar 10, 2024

⚠️ No Changeset found

Latest commit: 4e842d6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Member

@dummdidumm dummdidumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't suffice, it will fail on many packages, for example radix-svelte does work propertly on the current REPL but with this PR it fails. @PuruVJ said that unpkg does do some module resolution for packages that don't have an exports map etc, and that's missing in jsdelivr, so we would have to implement it ourselves.

@PuruVJ
Copy link
Collaborator

PuruVJ commented Mar 11, 2024

I added this line here in my original PR https://github.com/sveltejs/sites/pull/551/files#diff-292df1c211c573d5ee1e2b5a2caba399d3e405ad664c6fb99e28736dde95a80fR119-R136

I'm not sure whether its because of esm.run or jsdelivr. I remember one of these had the issue, so testing of that PR is needed to be fully sure

EDIT: It's JsDelivr

CleanShot 2024-03-11 at 15 42 52@2x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants