docs: use a canvas demo for $effect
#10745
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewing the
$effect
docs in light of #10740, I think we can make a few improvements. Submitting them as separate PRs so they can be discussed independently.The examples we use provide framing for how constructs are supposed to be used. I think we've been making a mistake, therefore, by using
console.log
in$effect
examples when$inspect
is a better tool for the job.The current example is rather confusing in other ways:
count
contains{double}
(mea culpa)double
changes because it's read inside asetTimeout
, but it will re-run whendouble
changes because it re-runs whencount
changes, anddouble
changes whencount
changes