each animate allow having comment siblings

sveltejs · Apr 8, 2022 · a8417f1 · a8417f1
1 parent f6fd8e1
commit a8417f1
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 1 deletion.
diff --git a/src/compiler/compile/nodes/EachBlock.ts b/src/compiler/compile/nodes/EachBlock.ts
@@ -63,7 +63,7 @@ export default class EachBlock extends AbstractBlock {
 		([this.const_tags, this.children] = get_const_tags(info.children, component, this, this));
 
 		if (this.has_animation) {
-			this.children = this.children.filter(child => !isEmptyNode(child));
+			this.children = this.children.filter(child => !isEmptyNode(child) && !isCommentNode(child));
 
 			if (this.children.length !== 1) {
 				const child = this.children.find(child => !!(child as Element).animation);
@@ -83,3 +83,6 @@ export default class EachBlock extends AbstractBlock {
 function isEmptyNode(node: INode) {
 	return node.type === 'Text' && node.data.trim() === '';
 }
+function isCommentNode(node: INode) {
+	return node.type === 'Comment';
+}
diff --git a/test/validator/samples/animation-comment-siblings/errors.json b/test/validator/samples/animation-comment-siblings/errors.json
@@ -0,0 +1 @@
+[]
diff --git a/test/validator/samples/animation-comment-siblings/input.svelte b/test/validator/samples/animation-comment-siblings/input.svelte
@@ -0,0 +1,9 @@
+<script>
+	export let things;
+	function foo() {}
+</script>
+
+{#each things as thing (thing)}
+	<!-- some comment -->
+	<div animate:foo></div>
+{/each}