[fix] do not be over-eager in removing unused CSS for dialog[open] (#…

…7495)
sveltejs · Apr 30, 2022 · a068719 · a068719
1 parent 2633500
commit a068719
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 1 deletion.
diff --git a/src/compiler/compile/css/Selector.ts b/src/compiler/compile/css/Selector.ts
@@ -21,7 +21,8 @@ enum NodeExist {
 }
 
 const whitelist_attribute_selector = new Map([
-	['details', new Set(['open'])]
+	['details', new Set(['open'])],
+	['dialog', new Set(['open'])]
 ]);
 
 export default class Selector {

diff --git a/test/css/samples/attribute-selector-dialog-open/expected.css b/test/css/samples/attribute-selector-dialog-open/expected.css
@@ -0,0 +1 @@
+dialog[open].svelte-xyz{display:grid}
diff --git a/test/css/samples/attribute-selector-dialog-open/input.svelte b/test/css/samples/attribute-selector-dialog-open/input.svelte
@@ -0,0 +1,7 @@
+<dialog>Hello</dialog>
+
+<style>
+	dialog[open] {
+		display: grid;
+	}
+</style>