fix: support class exports (#9465)

sveltejs · Nov 15, 2023 · 9ef3424 · 9ef3424 · vercel · Nov 15, 2023
1 parent 6f3dc04
commit 9ef3424
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 11 deletions.
diff --git a/.changeset/thirty-flowers-sit.md b/.changeset/thirty-flowers-sit.md
@@ -0,0 +1,5 @@
+---
+'svelte': patch
+---
+
+fix: support class exports
diff --git a/packages/svelte/src/compiler/phases/2-analyze/index.js b/packages/svelte/src/compiler/phases/2-analyze/index.js
@@ -577,7 +577,10 @@ const legacy_scope_tweaker = {
 			return next();
 		}
 
-		if (node.declaration.type === 'FunctionDeclaration') {
+		if (
+			node.declaration.type === 'FunctionDeclaration' ||
+			node.declaration.type === 'ClassDeclaration'
+		) {
 			state.analysis.exports.push({
 				name: /** @type {import('estree').Identifier} */ (node.declaration.id).name,
 				alias: null
@@ -681,7 +684,10 @@ const runes_scope_tweaker = {
 			return next();
 		}
 
-		if (node.declaration.type === 'FunctionDeclaration') {
+		if (
+			node.declaration.type === 'FunctionDeclaration' ||
+			node.declaration.type === 'ClassDeclaration'
+		) {
 			state.analysis.exports.push({
 				name: /** @type {import('estree').Identifier} */ (node.declaration.id).name,
 				alias: null

diff --git a/packages/svelte/src/compiler/phases/2-analyze/validation.js b/packages/svelte/src/compiler/phases/2-analyze/validation.js
@@ -453,15 +453,6 @@ export const validation_legacy = merge(validation, a11y_validators, {
 		// TODO check if it's a store subscription that's called? How likely is it that someone uses a store that contains a function?
 		error(node.init, 'invalid-rune-usage', callee.name);
 	},
-	ExportNamedDeclaration(node) {
-		if (
-			node.declaration &&
-			node.declaration.type !== 'VariableDeclaration' &&
-			node.declaration.type !== 'FunctionDeclaration'
-		) {
-			error(node, 'TODO', 'whatever this is');
-		}
-	},
 	AssignmentExpression(node, { state, path }) {
 		const parent = path.at(-1);
 		if (parent && parent.type === 'ConstTag') return;