Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

breaking: remove preserve option #622

Merged
merged 4 commits into from
Jun 12, 2024
Merged

Conversation

benmccann
Copy link
Member

closes #305
closes #312

Turns out the preserve option doesn't actually do anything useful anymore because it's now looking at lang and not type as it was originally. The original issues are already fixed without specifying preserve at all.

return { code: '', map: '' };
},
});
it('should NOT preprocess unrecognized languages', async () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that I forgot how the auto preprocessor is working 😅 I didn't remember it's skipping unknown languages 🤔

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At some point in the past it wasn't, but it's nice that it is now. Saved me from having to implement it!

I think it's not really that it's skipping unknown languages but that it's looking at the lang field, so you can specify whatever you want in type since it's not using that field. Then since this doesn't specify a lang it gets skipped.

@dummdidumm dummdidumm merged commit e46b53e into sveltejs:main Jun 12, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[auto preprocess] Don't try to preprocess unknown language Errors upon encountering schema.org markup
3 participants