This repository has been archived by the owner on Jan 11, 2023. It is now read-only.
Wait upto 30 seconds for server ready #985
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could we do |
|
I like seeing that some process is taking longer than expected, I think in this case it informs the user something's up with their underlying system. Too bad it's not very actionable, but I haven't seen an actual solution so not sure if there is a more helpful message. |
alexbjorlig
added a commit
to alexbjorlig/sapper
that referenced
this pull request
Oct 1, 2020
According to the source code here https://github.com/Rich-Harris/port-authority/blob/bf12e69618cc59dbc0d46a5132902df8a584e39f/src/wait.ts#L3, we can specify a timeout - and a default timeout of 5 seconds is not high enough for many bigger express applications (see issue 730). This PR is simply inspired by the dialog in pull request: sveltejs#985, but I thought it would just be simpler to create a new one.
|
Sorry this had gone unreviewed for so long. It looks like there's a merge conflict here. Maybe it's better to try to make sure SvelteKit works as desired than trying to get it in here at this point? |
|
Sure! |
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #730
Related: #1007