This repository has been archived by the owner on Jan 11, 2023. It is now read-only.
[WIP] Support Svelte 3 #538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Bringing this back on track... all tests now passing except the ones relating to |
Conduitry
reviewed
Feb 1, 2019
src/core/create_manifest_data.ts
Outdated
|
|
||
| if (/preload/.test(source)) { | ||
| try { | ||
| const { stats } = svelte.compile(source, { generate: false }); |
There was a problem hiding this comment.
I think we should use an empty warning handler here to suppress the display of any warnings while we're determining whether there's a preload. They'll be getting displayed during the main compilation anyway.
There was a problem hiding this comment.
good catch — added locally
|
There are some failing tests related to rollup/rollup#2677, but I think this is probably good to merge into master — I'm not anticipating a new release before Svelte 3 is ready. This PR incorporates the ideas in #546, #551, #552 and #554. |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't represent much work — basically the minimum required to get an app working. A particular annoyance is that we can no longer check for the existence of
Component.preload, because in Svelte 3 things likepreloadare separate named imports:import Component, { preload } from './Component.html';Rollup doesn't like that — it chokes when you try to import a name that the module doesn't export. We have to jump through some unpleasant hoops to get it to work, and even then it gives us a bunch of warnings. The solution, I think, is to precompile page/layout components so that we can see which ones have
preload, and add the imports more selectively.Anyway, I'll release an alpha version so that I can deploy the new (also very WIP) site.