Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle missing export error #119

Merged
merged 6 commits into from
Aug 3, 2020
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
13 changes: 13 additions & 0 deletions index.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ const { createFilter } = require('rollup-pluginutils');
const { encode, decode } = require('sourcemap-codec');

const major_version = +version[0];
const pkg_export_errors = new Set();

const { compile, preprocess } = major_version >= 3
? require('svelte/compiler.js')
Expand Down Expand Up @@ -50,6 +51,12 @@ function tryResolve(pkg, importer) {
return relative.resolve(pkg, importer);
} catch (err) {
if (err.code === 'MODULE_NOT_FOUND') return null;
if (err.code === 'ERR_PACKAGE_PATH_NOT_EXPORTED') {
if (!pkg_export_errors.has(pkg)) {
lukeed marked this conversation as resolved.
Show resolved Hide resolved
pkg_export_errors.add(pkg.replace(/\/package.json$/, ''));
}
return null;
pngwn marked this conversation as resolved.
Show resolved Hide resolved
}
throw err;
}
}
Expand Down Expand Up @@ -334,7 +341,13 @@ module.exports = function svelte(options = {}) {
}, this.warn);

css(writer);


}
if (pkg_export_errors.size < 1) return;

console.warn('\nrollup-plugin-svelte: The following packages did not export their `package.json` file so we could not check the `svelte` field. If you had difficulties importing svelte components from a package, please contact the author and ask them to export their package.json file.\n');
pngwn marked this conversation as resolved.
Show resolved Hide resolved
console.warn(Array.from(pkg_export_errors).map(s => `- ${s}`).join('\n') + '\n');
}
};
};
Empty file.
8 changes: 8 additions & 0 deletions test/node_modules/esm-component/package.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions test/node_modules/esm-component/src/Component.svelte

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Empty file.
6 changes: 6 additions & 0 deletions test/node_modules/esm-no-pkg-export/package.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

16 changes: 16 additions & 0 deletions test/test.js
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,22 @@ describe('rollup-plugin-svelte', () => {
);
});

it('ignores esm modules that do not export package.json', () => {
const { resolveId } = plugin();
assert.equal(
resolveId('esm-no-pkg-export', path.resolve('test/foo/main.js')),
null
);
});

it('resolves esm module that exports package.json', () => {
const { resolveId } = plugin();
assert.equal(
resolveId('esm-component', path.resolve('test/foo/main.js')),
path.resolve('test/node_modules/esm-component/src/Component.svelte')
);
});

it('ignores virtual modules', () => {
const { resolveId } = plugin();
assert.equal(
Expand Down