Handle ERR_PACKAGE_PATH_NOT_EXPORTED gracefully #109
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctavan
force-pushed
the
handle-missing-exports-gracefully
branch
from
22a941e
to
9da2f9c
Compare
|
I have been using your branch with one of my projects and while it is definitely a good fix and working well, it is incredibly noisy. I'm not sure what the best approach is here. When I say noisy, I mean a screen full of warnings. |
|
FYI, it was just mentioned in nodejs/node#33460 that nodejs/node#49445 is being considered as the intended solution to grabbing the |
|
Thanks for proposing a fix for this! I'm going to close this one for now in favor of #119, which reduces the amount of screen output a bit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes nodejs/modules#104
Closes nodejs/modules#108
I think that this is a more appropriate solution to nodejs/modules#104 than nodejs/modules#108
For more context see uuidjs/uuid#444 (comment) and nodejs/node#33460