Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(svelt:events): ensure m prop is synced #583

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pedroyremolo
Copy link

@pedroyremolo pedroyremolo commented Feb 17, 2024

Description

After solving the tutorial exercise of section Part 1. BasicSvelt > Events > DOM Events as requested by the tutorial, the pointer position was not being updated at the DOM. This was happening because the m object was not being assigned after changes, this PR solved it.

Disclaim: Opted for m = m; instead of whole object assignment because the next section already suggests it

Copy link

vercel bot commented Feb 17, 2024

@pedroyremolo is attempting to deploy a commit to the Svelte Team on Vercel.

A member of the Team first needs to authorize it.

@Conduitry
Copy link
Member

This isn't necessary. Assigning to m.x or m.y already invalidates m. The text updates when you just add the on:pointermove={handleMove}. What are you seeing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants